Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clades 24H, 24I #112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add clades 24H, 24I #112

wants to merge 2 commits into from

Conversation

corneliusroemer
Copy link
Member

I don't know how to update colors

I don't know how to update colors
@joverlee521
Copy link
Contributor

I'll take more detailed look at this tomorrow.

Noting for myself that the forecast page currently does not have the new clades:

Screenshot 2024-11-18 at 5 12 39 PM

This is likely because the sequences counts do not reach the clade_min_seq config

clade_min_seq: 2000

We can force include the new clades with something like (untested):

diff --git a/config/config.yaml b/config/config.yaml
index f0a2307..787ce8e 100644
--- a/config/config.yaml
+++ b/config/config.yaml
@@ -22,6 +22,7 @@ prepare_data:
         prune_seq_days: 12
         clade_min_seq: 2000
         clade_min_seq_days: 150
+        force_include_clades: "24H=24H 24I=24I"
     pango_lineages:
       global:
         included_days: 150

@corneliusroemer
Copy link
Member Author

I think we should lower thresholds in general. There are many interesting countries with relevant sequencing activity that are excluded. I did a test run with lower thresholds across the board and it looks good. Will share.

Sequencing activity keeps dropping, so without dropping thresholds the forecasts become increasingly irrelevant.

Same for pango lineages. LP.8 has around 140 sequences now. It's growing fast, it's been noteworthy for multiple weeks but will show only in a few weeks with current thresholds demanding 350 sequences.

I can make a proposal tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants